馃悰Check hostname for default domain #17911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
reviewed
Sep 7, 2018
| @@ -177,6 +179,43 @@ describe('Linker Manager', () => { | |||
| }); | |||
| }); | |||
|
|
|||
|
|
|||
| it('should add linker with no defaultDomain and matching hostname', () => { | |||
There was a problem hiding this comment.
with no defaultDomain -> with default destinationDomains
|
|
||
| return Promise.all(manager.allLinkerPromises_).then(() => { | ||
| manager.handleAnchorMutation(a); | ||
| return expect(a.href).to.not.equal('https://www.example.com'); |
There was a problem hiding this comment.
I was trying to avoid testing the linker in the linker-manager, but I agree it is probably better. Done.
lannka
approved these changes
Sep 7, 2018
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* check hostname * clean up rebase * tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the linker was comparing against the full url instead of just the hostname.