✨ Lotame vendor - set disableKeyAppend to true #18051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e we do not want the variable prefix.
bradfrizzell
approved these changes
Sep 18, 2018
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Sep 20, 2018
…e we do not want the variable prefix. (ampproject#18051)
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Oct 10, 2018
…e we do not want the variable prefix. (ampproject#18051)
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
…e we do not want the variable prefix. (ampproject#18051)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is in response to complaints from our clients. When we changed from the old remote.html implementation to RTC, the suffix "_lotame" started to be added to variable names. This was causing confusion, and it was decided that everyone would be happier if we simply disabled that behavior.