Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛amp-video-iframe: add additional iframe sandbox attributes allowing video-ad clickthrough #18228

Merged
merged 2 commits into from Nov 12, 2018

Conversation

klipstein
Copy link
Contributor

Video ads (Pre-/Mid-/Postrolls) that get rendered inside amp-video-iframe currently cannot escape the given iframe sandbox. So that video-ad clickthrough targets can be opened by the embedded video-player the following iframe sandbox attributes were added:

  • allow-popups-to-escape-sandbox
  • allow-top-navigation-by-user-activation

- allow-popups-to-escape-sandbox
- allow-top-navigation-by-user-activation

so that video-ad clickthrough targets can be reached
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@klipstein
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Member

@alanorozco alanorozco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@klipstein
Copy link
Contributor Author

@alanorozco do I need to adjust something in this pull so that it can be merged?

@alanorozco
Copy link
Member

@klipstein Could you merge from the latest upstream master and push to this PR?

@klipstein
Copy link
Contributor Author

@alanorozco I've merged latest master. Thanks for your help.

@alanorozco alanorozco merged commit d823cc4 into ampproject:master Nov 12, 2018
@alanorozco
Copy link
Member

@klipstein Merged, thanks! Expect your changes to be in the next dev channel release.

Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Nov 28, 2018
- `allow-popups-to-escape-sandbox`
- `allow-top-navigation-by-user-activation`

This is so that video-ad clickthrough targets can be reached.
@cramforce
Copy link
Member

Oh hei @klipstein, good to see you on the internetz!

@klipstein
Copy link
Contributor Author

@cramforce ohai! Glad to see you too and that you started this nice little project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants