New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛amp-video-iframe: add additional iframe sandbox attributes allowing video-ad clickthrough #18228
🐛amp-video-iframe: add additional iframe sandbox attributes allowing video-ad clickthrough #18228
Conversation
- allow-popups-to-escape-sandbox - allow-top-navigation-by-user-activation so that video-ad clickthrough targets can be reached
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
@alanorozco do I need to adjust something in this pull so that it can be merged? |
@klipstein Could you merge from the latest |
…l-sandbox-attributes
@alanorozco I've merged latest master. Thanks for your help. |
@klipstein Merged, thanks! Expect your changes to be in the next dev channel release. |
- `allow-popups-to-escape-sandbox` - `allow-top-navigation-by-user-activation` This is so that video-ad clickthrough targets can be reached.
Oh hei @klipstein, good to see you on the internetz! |
@cramforce ohai! Glad to see you too and that you started this nice little project :) |
Video ads (Pre-/Mid-/Postrolls) that get rendered inside
amp-video-iframe
currently cannot escape the given iframe sandbox. So that video-ad clickthrough targets can be opened by the embedded video-player the following iframe sandbox attributes were added: