Move sendRequest_ logic from amp-analytics.js to requests.js #18263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyx
suggested changes
Sep 21, 2018
zhouyx
approved these changes
Sep 21, 2018
GoTcWang
pushed a commit
to GoTcWang/amphtml
that referenced
this pull request
Sep 25, 2018
…ect#18263) * Move sendRequest_ logic from amp-analytics.js to requests.js * fix presubmit
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Oct 10, 2018
…ect#18263) * Move sendRequest_ logic from amp-analytics.js to requests.js * fix presubmit
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
…ect#18263) * Move sendRequest_ logic from amp-analytics.js to requests.js * fix presubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring PR to unblock #6031