馃摉 Correcting a typo in uas.md file #18292
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 馃摑 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
Hello @erwinmombay , |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
| @@ -51,7 +51,7 @@ Note that the `width` and `height` mentioned should be maximum of the width-high | |||
| <amp-ad | |||
| width="300" height="250" | |||
| type="uas" | |||
| json='{"accId": "132109", "adUnit": "10002912", "sizes": [[300, 250]], "targetings": {"country": ["India", "USA"], "car": "Civic"}, "locLat": "12.24", "locLon": "24.13", "locSrc": "wifi", "pageURL": "http://mydomain.com"}'> | |||
| json='{"accId": "132109", "adUnit": "10002912", "sizes": [[300, 250]], "targetings": {"country": ["India", "USA"], "car": "Civic"}, "locLat": "12.24", "locLon": "24.13", "locSrc": "1", "pageURL": "http://mydomain.com"}'> | |||
There was a problem hiding this comment.
I didn't find the supported value for locSrc. Is 1 supported? wifi might actually make sense for "location source"
There was a problem hiding this comment.
Hello @lannka ,
Thank you for your suggestion.
PubMatic UAS tag needs to pass the value for locSrc parameter as per a pre-defined map of values thus we are changing it from "wifi" to "1".
There was a problem hiding this comment.
OK, that sounds good. But if you folks are the maintainer of PubMatic, I suggest you provide the full map in the documentation as well.
|
Thank you @lannka |
* accId to be used instead of accountId * updating value of locSrc param in documentation
* accId to be used instead of accountId * updating value of locSrc param in documentation
馃摉 Correcting a typo in uas.md file