Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖Update misspelling of behavior in amp-accordion example #18330

Merged
merged 2 commits into from Sep 24, 2018

Conversation

sanchezedgar
Copy link
Contributor

Addressing issue #18106

"Behavior" is misspelled as "behaviour" in the file examples/visual-tests/amp-by-example/components/amp-accordion/index.html

@alanorozco
Copy link
Member

Thanks! Would you mind undoing the newline changes?

Copy link
Contributor

@nainar nainar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes a lot of changes other than the spelling change only. Could you please revert those? Thank you!

@alanorozco alanorozco changed the title 📖Update misspelling of behavior in amp-accordian example 📖Update misspelling of behavior in amp-accordion example Sep 24, 2018
@sanchezedgar
Copy link
Contributor Author

Updated, my IDE was set to remove whitespace on save by default.

Copy link
Contributor

@nainar nainar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change! Will merge once Travis is done running!

@nainar nainar merged commit f542641 into ampproject:master Sep 24, 2018
GoTcWang pushed a commit to GoTcWang/amphtml that referenced this pull request Sep 25, 2018
…18330)

* Update spelling of behavior

* Prevented whitespaces from being removed by IDE
torch2424 pushed a commit to torch2424/amphtml that referenced this pull request Oct 10, 2018
…18330)

* Update spelling of behavior

* Prevented whitespaces from being removed by IDE
Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Nov 28, 2018
…18330)

* Update spelling of behavior

* Prevented whitespaces from being removed by IDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants