Fix NPE caused by race condition when AMP page state changes before amp-analytics finishes initialization #18400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mp-analytics finishes initialization
lannka
changed the title
calebcordry
approved these changes
Sep 26, 2018
zhouyx
reviewed
Sep 26, 2018
| @@ -178,8 +182,13 @@ export class AmpAnalytics extends AMP.BaseElement { | |||
| return false; | |||
| } | |||
|
|
|||
| // Page was unloaded - free up owned resources. | |||
| this.transport_.deleteIframeTransport(); | |||
| if (this.iniPromise_) { | |||
There was a problem hiding this comment.
Hmmmm, I feel we should stop initiating iframeTransport once unlaid out, instead of wait for the promise to resolve and delete the iframe again.
I am ok to have this as a temporary solution but longterm this should be considered together with #18231
There was a problem hiding this comment.
This can be tricky to implement, as promise cannot be canceled.
There was a problem hiding this comment.
even if we could cancel a promise, to support the following lifecycle:
active -> inactive : unlayoutCallback
inactive -> active : resumeCallback
we have to initialize everything in resumeCallback as well.
|
Test added |
This was referenced Sep 27, 2018
Closed
calebcordry
pushed a commit
that referenced
this pull request
Sep 27, 2018
…mp-analytics finishes initialization (#18400) * Fix NPE caused by race condition when AMP page state changes before amp-analytics finishes initialization * add tests
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Oct 10, 2018
…mp-analytics finishes initialization (ampproject#18400) * Fix NPE caused by race condition when AMP page state changes before amp-analytics finishes initialization * add tests
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
…mp-analytics finishes initialization (ampproject#18400) * Fix NPE caused by race condition when AMP page state changes before amp-analytics finishes initialization * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18395