Fix Doubleclick SRA race condition #18477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshienbrood
approved these changes
Oct 1, 2018
keithwrightbos
added a commit
that referenced
this pull request
Oct 3, 2018
See fix #18477, verified against dev-channel that issue is no longer present. Will re-enable on production once fix is global and results on canary look correct.
keithwrightbos
added a commit
that referenced
this pull request
Oct 3, 2018
* Doubleclick: Re-enable SRA 1% experiment for canary See fix #18477, verified against dev-channel that issue is no longer present. Will re-enable on production once fix is global and results on canary look correct. * Include prod as this will go live with the fix
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Oct 10, 2018
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Oct 10, 2018
* Doubleclick: Re-enable SRA 1% experiment for canary See fix ampproject#18477, verified against dev-channel that issue is no longer present. Will re-enable on production once fix is global and results on canary look correct. * Include prod as this will go live with the fix
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* Doubleclick: Re-enable SRA 1% experiment for canary See fix ampproject#18477, verified against dev-channel that issue is no longer present. Will re-enable on production once fix is global and results on canary look correct. * Include prod as this will go live with the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address race condition where resolver for sendXhrRequest chain is being recreated between SRA request and response causing later ad blocks to fail to render.