🐛Fix a2a for next article links in amp-next-page

[sparhami]

Fixes #18512

[tchirag]

Is this removal of Analytics trigger on amp-next-page?

[sparhami]

Is this removal of Analytics trigger on amp-next-page?

I believe that the event that triggers for a2a within <amp-next-page> would have triggered before this fix as well, since the code for the event happens before the line with the error. The actual amp to amp navigation would not have happened though.

[tchirag]

Is this removal of Analytics trigger on amp-next-page?

I believe that the event that triggers for a2a within <amp-next-page> would have triggered before this fix as well, since the code for the event happens before the line with the error. The actual amp to amp navigation would not have happened though.

Unfortunately with this push, trigger for pageview event on Google Analytics has stopped on amp-next-page. To explain, pageview event gets triggered on first page however doesnt get triggered on 2nd and 3rd page which are loaded using amp-next-page. Is this expected outcome?

[sparhami]

Unfortunately with this push, trigger for pageview event on Google Analytics has stopped on amp-next-page. To explain, pageview event gets triggered on first page however doesnt get triggered on 2nd and 3rd page which are loaded using amp-next-page. Is this expected outcome?

Do you mean an analytics event when the user scrolls and the next page is loaded or when the user clicks on a link (in the recommendation box). To the best of my knowledge, this change should only affect when the user clicks on a link. Are you seeing the missing analytics when you click on one of those links?

@peterjosling do you have any insight as to what may be going on? I'm not familiar with the amp 2 amp navigation flow, could there be some problem there?

[sparhami]

Hmm, I wonder if this is related to the fact that we strip the <amp-analytics> config from <amp-next-page>. It may be that the analytics was working before because it was a hard page navigation. Now, the event fires to let it know that an a2a navigation happened, then we do an a2a navigation. It could be that nothing is actually listening for that event though.

[tchirag]

Analytics event doesnt get triggered when the user scrolls and the next page is loaded. I.e. Earlier, Upon loading of next page a separate page event was getting triggered which is not happening now. Could you pls look into this?

…

On Thu, Oct 11, 2018 at 11:20 PM Sepand Parhami ***@***.***> wrote: Unfortunately with this push, trigger for pageview event on Google Analytics has stopped on amp-next-page. To explain, pageview event gets triggered on first page however doesnt get triggered on 2nd and 3rd page which are loaded using amp-next-page. Is this expected outcome? Do you mean an analytics event when the user scrolls and the next page is loaded or when the user clicks on a link (in the recommendation box <https://www.ampproject.org/docs/reference/components/amp-next-page#recommendation-box>. To the best of my knowledge, this change should only affect when the user clicks on a link. Are you seeing the missing analytics when you click on one of those links? @peterjosling <https://github.com/peterjosling> do you have any insight as to what may be going on? I'm not familiar with the amp 2 amp navigation flow, could there be some problem there? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#18517 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE4FyOLrfb-tkx7Q2ps0YB2h35G69RPyks5uj4T_gaJpZM4XE8ye> .

[sparhami]

@lannka Are you aware of any issues or changes with <amp-analytics> and/or <amp-next-page> that might prevent the analytics triggering?

[peterjosling]

Analytics are currently disabled in child documents. #15807

[tchirag]

Even creating DFP Ad Units isnt possible currently?