Load amp-pixel and amp-analytics independent of where on the page they appear. #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y appear. Before this, based on position, analytics may e.g. not load immediate when the page starts out scrolled down. Also adds `display:none` to the tags, because they have no layout anyway. This slightly improves rendering speed. Especially now that they are `position:fixed`. Fixes ampproject#1864
|
@avimehta FYI |
|
lgtm |
cramforce
added a commit
that referenced
this pull request
Feb 9, 2016
Load amp-pixel and amp-analytics independent of where on the page they appear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, based on position, analytics may e.g. not load immediately when the page starts out scrolled down.
Also adds
display:noneto the tags, because they have no layout anyway. This slightly improves rendering speed. Especially now that they areposition:fixed.Fixes #1864