馃悰Fix IE11 with a basic polyfill #18941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
reviewed
Oct 24, 2018
third_party/react-dates/index.js
Outdated
| return []; | ||
| } | ||
|
|
||
| return [].concat(arrayLike); |
There was a problem hiding this comment.
Might be better to do a for loop? Concat will only spread arrays, not array-likes.
third_party/react-dates/index.js
Outdated
| // A very basic polyfill for Array.from, | ||
| // to avoid needing to use a full 3p implementation | ||
| if (!Array.from) { | ||
| Array.from = function (arrayLike) { |
There was a problem hiding this comment.
Object.defineProperty(Array, 'from', {
writable: true,
enumerable: false,
configurable: true,
value: poly,
});
|
@jridgewell PTAL |
jridgewell
approved these changes
Oct 25, 2018
|
Thank you for your review! |
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* Fix IE11 with a basic polyfill * review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18184 with a partial polyfill instead of the full polyfill from #18879
The partial polyfill is OK because the
Array.fromcall in_toConsumableArray(generated from the spread operator usages) is only ever called with Arrays orfalse:https://github.com/airbnb/react-dates/blob/f48b820449b2a460761ead4c056ccfac2322bb78/src/components/DayPickerNavigation.jsx#L109-L123