🐛 Doubleclick-Impl.js: Updates the logic in getPageParameters so that the psts param is not included if empty #19027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevitzky
approved these changes
Oct 29, 2018
warrengm
pushed a commit
to warrengm/amphtml
that referenced
this pull request
Oct 30, 2018
… the psts param is not included if empty (ampproject#19027) * Initial commit. * Fixes tests.
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
… the psts param is not included if empty (ampproject#19027) * Initial commit. * Fixes tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the logic for adding the psts param to the URL so that it is not included when there are no pageview tokens to include. Also added tests to check for this.