✨ Add binding for amp-date-picker min attribute #19035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvializ
force-pushed
the
feature/adp-bind-min
branch
from
43cd16c
to
611c438
Compare
nainar
reviewed
Oct 29, 2018
| @@ -53,7 +53,7 @@ export function withDatePickerCommon(WrappedComponent) { | |||
| */ | |||
| function isOutsideRange(min, max, date) { | |||
| const maxInclusive = max && moment(max); | |||
| const minInclusive = min && moment(min); | |||
| const minInclusive = min ? moment(min) : getDefaultMinDate(max); | |||
There was a problem hiding this comment.
shouldn't this be getDefaultMinDate(min)?
There was a problem hiding this comment.
No, but the method name is somewhat confusing. The default minimum date depends on what the maximum date is. The parameter is named max in the function definition to help clarify
| @@ -173,6 +173,9 @@ attr_lists: { | |||
| blacklisted_value_regex: "__amp_source_origin" | |||
| } | |||
| attrs: { name: "week-day-format" } | |||
| # amp-bind | |||
| attrs: { name: "[max]" } | |||
| attrs: { name: "[min]" } | |||
There was a problem hiding this comment.
@honeybadgerdontcare FYI validator change.
aghassemi
approved these changes
Oct 30, 2018
| @@ -33,7 +33,7 @@ export function withDatePickerCommon(WrappedComponent) { | |||
| const moment = requireExternal('moment'); | |||
|
|
|||
| /** | |||
| * @param {!moment} max | |||
| * @param {string} max | |||
There was a problem hiding this comment.
can this stay {!moment} if you pass moment(max) from isOutsideRange ?
There was a problem hiding this comment.
Sure, that could eliminate the extra call to moment
honeybadgerdontcare
approved these changes
Oct 30, 2018
cvializ
force-pushed
the
feature/adp-bind-min
branch
2 times, most recently
from
62d5485
to
942e247
Compare
cvializ
force-pushed
the
feature/adp-bind-min
branch
from
942e247
to
9631878
Compare
twifkak
pushed a commit
to twifkak/amphtml
that referenced
this pull request
Oct 31, 2018
Merged
twifkak
added a commit
that referenced
this pull request
Oct 31, 2018
- cl/219385362 Revision bump for #19035
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* Add binding for amp-date-picker min attribute * Clarify getDefaultMinDate behavior and remove extra moment call
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
- cl/219385362 Revision bump for ampproject#19035
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16410
Implements, documents and tests validation of
amp-bindbindings for the attributesminandmaxonamp-date-picker./to @nainar
/cc @choumx