Subscriptions service public method to render the dialog with the current entitlement. #19053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent entitlements.
prateekbh
approved these changes
Oct 31, 2018
jpettitt
approved these changes
Oct 31, 2018
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
…rent entitlements. (ampproject#19053)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the
amp-storyintegration ofamp-subscriptions, we need to be able to control what is displayed in the dialog, and when.amp-storyhas a soft (notification) paywall, and a hard (navigation blocking) paywall.Soft: only visible on the cover page, can be dismissed, used for metering
Hard: only visible when trying to navigate to a protected page, used to login/subscribe
To support this,
amp-storyneeds an additional method that re-renders the dialog, using the current entitlement, based on the subscriptions-dialog templates available in the DOM.This method: