fixing regexp #19065
Merged
fixing regexp #19065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
reviewed
Nov 1, 2018
| @@ -31,8 +31,7 @@ const gulp = $$.help(require('gulp')); | |||
| exports.createModuleCompatibleES5Bundle = function(src) { | |||
| return gulp.src('dist/' + src) | |||
| .pipe($$.sourcemaps.init({loadMaps: true})) | |||
| .pipe($$.rename(src.replace(/\.js$/, '-module.js'))) | |||
| .pipe($$.regexpSourcemaps(/(global\?global:\w*})\(this\)/, '$1(self)', 'module-global')) | |||
| .pipe($$.regexpSourcemaps(/(window.global\?window.global:\w*)this/, '$1self', 'module-global')) | |||
There was a problem hiding this comment.
just for my own knowledge how is the regexp name used (what is its usefulness)?
There was a problem hiding this comment.
@jridgewell , i wanted to ask that too
There was a problem hiding this comment.
I think it's the filename this new code will be associated with.
erwinmombay
approved these changes
Nov 1, 2018
|
@googlebot are you stuck? |
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* fixing regexp * adding shadow v0 bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIUC the change is required due to the new closure compiler declares global?global:this in a different way