Do not validate for #development=1 when on AMP Caches #19096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gregable
approved these changes
Nov 1, 2018
twifkak
added a commit
to twifkak/amphtml
that referenced
this pull request
Nov 2, 2018
Merged
twifkak
added a commit
that referenced
this pull request
Nov 3, 2018
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* do not validate AMP Cache URLs with #development=1 * add cloudflare * clean up * eslint fixes * whitelist validator-in-browser * whitelist
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* cl/219531121 Revision bump for ampproject#17481 * cl/219850294 Allow `http` scheme for links in email spec * cl/219866890 Revision bump for ampproject#19043 * cl/219867113 Revision bump for ampproject#18981 * cl/219877087 Make ESlint happy. * cl/219882876 Fix lint for ampproject#19096
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19082