♻️ Fixed issue with CLIENT_ID for pressboard analytics vendor #19104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 18, 2018 16:44
|
@zhouyx Hi, its me again :), can you please merge this? its a simple fix for our cookies. |
|
@zhouyx , I'm not exactly sure why the travis integration check failed, can you please re-run it? or tell me what to do? I only changed 2 lines. |
zhouyx
approved these changes
Nov 5, 2018
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
…ject#19104) * added pressboard as an analytics vendor * fixed travis issues * fixed a couple more bugs to pass travis tests * fixed another bug * added pressboard example * added/removed params to pressboard analytics * fixed a lint error * fixed requestCount param * added pressboard as an ad vendor in amp-ad * fixed linting issue * fixed another lint error * updated vendor-requests test * insert pressboard alphabetically * fixed a bug * moved amp-ad changes into a separate pull request * fixed sorting issue * add pressboard to amp-ad vendors * update docs link * minor changes * fixed validation issue * implemented renderStart * added comment * removed pressboard from feature_tests * removed comment * fixed clientId issue * fixed lint error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue with CLIENT_ID for pressboard analytics vendor