-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch amp-access #1914
Launch amp-access #1914
Conversation
b5fdc72
to
3f400f3
Compare
3f400f3
to
a96496d
Compare
@dvoytenko LGTM after rebase to get tests green |
@@ -91,8 +87,7 @@ export class AccessService { | |||
installStyles(this.win.document, $CSS$, () => {}); | |||
|
|||
/** @const @private {boolean} */ | |||
this.isExperimentOn_ = (isExperimentOn(this.win, EXPERIMENT) || | |||
isDevChannel(this.win)); | |||
this.isExperimentOn_ = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason why we're leaving the flag in? just temporary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I'm currently in preference to do experiment cleanup after the fact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
LGTM |
/cc @cramforce @ashwinlimaye @sebastianbenz @andreban