Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't encode ExpandStringAsync #19161

Merged
merged 3 commits into from Nov 6, 2018
Merged

Don't encode ExpandStringAsync #19161

merged 3 commits into from Nov 6, 2018

Conversation

calebcordry
Copy link
Member

@calebcordry calebcordry commented Nov 6, 2018

fixes #19126

@calebcordry calebcordry merged commit 4062362 into ampproject:master Nov 6, 2018
@calebcordry calebcordry deleted the noencode-string branch November 6, 2018 19:56
cvializ pushed a commit that referenced this pull request Nov 7, 2018
* don't encode

* remove only

* pixel test
Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Nov 28, 2018
* don't encode

* remove only

* pixel test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amp-analytics double encoded macro in extraUrlParams
4 participants