Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Intersection Observer Polyfill Mutation Observer - Fixed Race Condition #19168

Merged
merged 20 commits into from Nov 16, 2018
Merged

🐛Intersection Observer Polyfill Mutation Observer - Fixed Race Condition #19168

merged 20 commits into from Nov 16, 2018

Commits on Nov 6, 2018

  1. Got a working half-broken page that we can test with

    @torch2424
    torch2424 committed Nov 6, 2018
    Copy the full SHA
    7ef9930 View commit details
    Browse the repository at this point in the history

  2. COnfirmed the bug is that the pass isn't long enough

    @torch2424
    torch2424 committed Nov 6, 2018
    Copy the full SHA
    ad491aa View commit details
    Browse the repository at this point in the history

  3. Going to go home. But I learned that it doesn't fire until the child … 

    …image element is created.
    @torch2424
    torch2424 committed Nov 6, 2018
    Copy the full SHA
    63caf4b View commit details
    Browse the repository at this point in the history

  4. I was doing something

    @torch2424
    torch2424 committed Nov 6, 2018
    Copy the full SHA
    2be1f3b View commit details
    Browse the repository at this point in the history

  5. Fixed the polyfill completely

    @torch2424
    torch2424 committed Nov 6, 2018
    Copy the full SHA
    59f561e View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2018

  1. Fixed linting

    @torch2424
    torch2424 committed Nov 7, 2018
    Copy the full SHA
    c17cb5c View commit details
    Browse the repository at this point in the history

  2. Fixed all precommit checks

    @torch2424
    torch2424 committed Nov 7, 2018
    Copy the full SHA
    87ec925 View commit details
    Browse the repository at this point in the history

  3. Removed the one-off fandango example

    @torch2424
    torch2424 committed Nov 7, 2018
    Copy the full SHA
    f96fd1b View commit details
    Browse the repository at this point in the history

  4. Made PR Changes

    @torch2424
    torch2424 committed Nov 7, 2018
    Copy the full SHA
    0eba342 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2018

  1. Created an onNextPass for resources

    @torch2424
    torch2424 committed Nov 10, 2018
    Copy the full SHA
    d5051b9 View commit details
    Browse the repository at this point in the history

  2. Fixed tests for ampdoc

    @torch2424
    torch2424 committed Nov 10, 2018
    Copy the full SHA
    9892c8e View commit details
    Browse the repository at this point in the history

  3. Removed the original getLayoutRect

    @torch2424
    torch2424 committed Nov 10, 2018
    Copy the full SHA
    42a9964 View commit details
    Browse the repository at this point in the history

  4. Removed a dangling opt_calledFromMutationObserver

    @torch2424
    torch2424 committed Nov 10, 2018
    Copy the full SHA
    c7282f8 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2018

  1. Made PR Changes

    @torch2424
    torch2424 committed Nov 13, 2018
    Copy the full SHA
    241a4fe View commit details
    Browse the repository at this point in the history

  2. Fixed refresh tests for intersection observer

    @torch2424
    torch2424 committed Nov 13, 2018
    Copy the full SHA
    05f8046 View commit details
    Browse the repository at this point in the history

  3. Removed returns

    @torch2424
    torch2424 committed Nov 13, 2018
    Copy the full SHA
    e75f2b5 View commit details
    Browse the repository at this point in the history

  4. Fixed some linting errors

    @torch2424
    torch2424 committed Nov 13, 2018
    Copy the full SHA
    14fc692 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2018

  1. Made PR Changes

    @torch2424
    torch2424 committed Nov 14, 2018
    Copy the full SHA
    095f94f View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2018

  1. Merge branch 'master' of https://github.com/torch2424/amphtml into fa… 

    …ndango-bug-fix-no-example
    @torch2424
    torch2424 committed Nov 15, 2018
    Copy the full SHA
    9bf91c1 View commit details
    Browse the repository at this point in the history

  2. Fixed linting errors

    @torch2424
    torch2424 committed Nov 15, 2018
    Copy the full SHA
    5861c3b View commit details
    Browse the repository at this point in the history