Docking UX refinements #19179
Merged
Docking UX refinements #19179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alanorozco
commented
Nov 7, 2018
•
alanorozco
commented
- Refines animation breakpoints, thresholds and timeouts.
- Adds a repositioning transition for undocking.
- No longer docks to bottom.
- Fixes a variety of Chrome/Android issues.
- Fixes clipping on Safari.
- Adds placeholder treatment with icon and blurred poster.
alanorozco
commented
Nov 7, 2018
| * @return {!Element} | ||
| * @private | ||
| */ | ||
| const ShadowLayer = html => |
There was a problem hiding this comment.
Structuring the templates like this has a few benefits:
- Added readability.
- Reduced length of constructor.
- Automatic syntax highlighting in a lot of editors + plugins (by using
htmlinstead ofhtmlFor()directly).
| '%s/experiments.html', | ||
| urls.cdn); | ||
| '%s', | ||
| urls.cdn + '/experiments.html'); |
There was a problem hiding this comment.
Doing like this so string doesn't get split in console.
| unmuteButton, | ||
| } = this.getControls_(); | ||
| const overlay = this.getOverlay_(); | ||
| installShowControlsOnTapOrHover_(element) { |
There was a problem hiding this comment.
Now shows up on hover.
| if (this.isDragging_ || | ||
| this.ignoreDueToSize_(video) || | ||
| !this.isValidSize_(video) || |
src/service/video/docking.js
Outdated
| * @private | ||
| */ | ||
| isValidScrollingDirection_() { | ||
| return this.currentlyDocked_ || |
There was a problem hiding this comment.
Now only allows scrolling up for docking, while scrolling down works to undock as well.
| return; | ||
| } | ||
| this.dock_(video, target); | ||
| if (this.currentlyDocked_) { |
There was a problem hiding this comment.
If the video is no longer dockable on resize, undock it.
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
- Shows controls on hover. - Refines animation breakpoints, thresholds and timeouts. - Adds a repositioning transition for undocking. - No longer docks to bottom. - Fixes a variety of Chrome/Android issues. - Fixes clipping on Safari. - Adds placeholder treatment with icon and blurred poster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.