Integration tests for amp-video-iframe #19196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
approved these changes
Nov 14, 2018
| // TODO(alanorozco): On integration tests, `getLayoutBox` will returned | ||
| // a cached default value, which makes these assertions fail. Move to | ||
| // `describes.integration` to see if that fixes it. | ||
| if (!element.hasAttribute('i-amphtml-integration-test')) { |
There was a problem hiding this comment.
Would !getMode().test work instead?
There was a problem hiding this comment.
That would be the case, but this is unit-tested as well, so we need to discern between the integration bug and the unit tests.
|
Seems like this has broken master: https://travis-ci.org/ampproject/amphtml/jobs/455224522#L714 |
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(in progress)