Remove vsync guards to fx presets #19197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
reviewed
Nov 9, 2018
| }); | ||
| fxElement.initialTrigger = true; | ||
| }); | ||
| const style = computedStyle(fxElement.getAmpDoc().win, |
There was a problem hiding this comment.
@nainar with this change, we are assuming the element is laidout by the time the fx triggers which may or ma not be the case. I think we need to keep the mutateElement for the initial trigger.
a good test for this would be fly-in-left for an image that more than 3 viewport height down the page initially.
There was a problem hiding this comment.
Made the change in the latest PR you are right. Was broken for one of the examples in article-fly-in.amp.html
aghassemi
approved these changes
Nov 13, 2018
|
@nainar Just remembered. Do we also call |
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* Remove vsync guards to fx presets * Add initial trigger guards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #19022 by ensuring that all updates to the animations are synchronous and not batched.