New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove text that is no longer needed #19208
Remove text that is no longer needed #19208
Conversation
I might miss something but seems the (I was actually following this instruction to debug the other bug. otherwise i could have spent more time on it). |
I agree, for the iframe-transport example. But for this one, I'm just
trying to illustrate variable substitution in the analytics ping, which
doesn't require the iframe to load properly.
…On Fri, Nov 9, 2018 at 3:48 PM Hongfei Ding ***@***.***> wrote:
I might miss something but seems the example-3p-vendor is still used in
the example. I think the instruction is still very helpful right?
(I was actually following this instruction to debug the other bug.
otherwise i could have spent more time on it).
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#19208 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACV2B9476piak9voGQHD_Hjva503AkYGks5uteoPgaJpZM4YXQeL>
.
|
but seems to me the amp-analytics example on the page would not work without adding the config for 'example-3p-vendor' |
Here's the result of running the code that was submitted - note the red
line in the network log at the bottom:
https://screenshot.googleplex.com/iajMQZW51pM
…On Fri, Nov 9, 2018 at 4:56 PM Hongfei Ding ***@***.***> wrote:
but seems to me the amp-analytics example on the page would not work
without adding the config for 'example-3p-vendor'
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#19208 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACV2B3WIx2ywpTTVYI7SnCWU4k7JpLiDks5utfoKgaJpZM4YXQeL>
.
|
OK, seems |
The removed instructions are no longer necessary to make the example work.