Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove text that is no longer needed #19208

Merged
merged 1 commit into from Nov 9, 2018

Conversation

jonkeller
Copy link
Contributor

The removed instructions are no longer necessary to make the example work.

@keithwrightbos keithwrightbos merged commit dcabeda into ampproject:master Nov 9, 2018
@lannka
Copy link
Contributor

lannka commented Nov 9, 2018

I might miss something but seems the example-3p-vendor is still used in the example. I think the instruction is still very helpful right?

(I was actually following this instruction to debug the other bug. otherwise i could have spent more time on it).

@jonkeller
Copy link
Contributor Author

jonkeller commented Nov 9, 2018 via email

@lannka
Copy link
Contributor

lannka commented Nov 9, 2018

but seems to me the amp-analytics example on the page would not work without adding the config for 'example-3p-vendor'

@jonkeller
Copy link
Contributor Author

jonkeller commented Nov 9, 2018 via email

@lannka
Copy link
Contributor

lannka commented Nov 9, 2018

OK, seems <amp-analytics type="unknown"> does not throw. Thanks for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants