Restrict the number of global replacements variable #19233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
approved these changes
Nov 10, 2018
lannka
reviewed
Nov 10, 2018
| // Restrict the number of replacement params to globalVaraibleSource | ||
| // Please consider adding the logic to amp-analytics instead. | ||
| // Please contact @lannka or @zhouyx if the test fail. | ||
| expect(variables).to.have.lengthOf.within(0, 69); |
There was a problem hiding this comment.
let's make it exactly equal.
so we timely reduce the size when we move things out.
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* add test * address comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we agreed, need a test to restrict the number of global replacements variables.