Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency google-closure-compiler to v20181028 #19244

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Nov 11, 2018

This PR contains the following updates:

Package Type Update Change References
google-closure-compiler devDependencies major 20180910.1.0 -> 20181028.0.1 homepage, source

Release Notes

google/closure-compiler-npm

v20181028.0.1

Compare Source

v20181028.0.0

Compare Source

v20181008.0.0

Compare Source


Renovate configuration

馃搮 Schedule: At any time (no schedule defined).

馃殾 Automerge: Disabled by config. Please merge this manually once you are satisfied.

鈾伙笍 Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

馃敃 Ignore: Close this PR and you won't be reminded about this update again.


This PR has been generated by Renovate Bot. View repository job log here.

@rsimha
Copy link
Contributor

rsimha commented Nov 15, 2018

@danielrozenberg I'm seeing the odd PR like this, where Travis was fully green, but Percy says it didn't receive any snapshots. Any idea what's going on here?

@danielrozenberg
Copy link
Member

Not 100% sure why this happens here, but #19327 should give us more visibility. Before #19327, fatal errors might not get printed because we call process.exit() before the error messages get flushed to stdout/stderr

@rsimha rsimha merged commit 7838f8c into ampproject:master Nov 15, 2018
@renovate-bot renovate-bot deleted the renovate/google-closure-compiler-20181028.x branch November 16, 2018 00:29
Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants