🐛Only add runtime classNames custom-elements not in templates #19260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvializ
changed the title
cvializ
changed the title
jridgewell
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18183
In browsers that do not support
<template>natively, AMP custom-elements in templates have runtime classNames added. I believe this is not the intended behavior.This caused problems when parent elements called
measureMutateElement.measureMutateElementqueries child elements with thei-amphtml-elementclassName and attempts to reference theirresources_methods. The custom-elements inside the templates are assigned the runtime classNames, but don't reach the code path where theirresources_get assigned, and so aReference Errorwould occur.This PR fixes that error from occurring by exiting from
connectedCallbackbefore the runtime classnames are added. This preventsmeasureMutateElementfrom querying custom-elements inside<template>tags.Do you foresee any issues with this approach?
/to @jridgewell @choumx
/cc @dvoytenko