Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fixed typo in onInfoDialogStateUpdated_ method JSDoc. #19268

Merged
merged 1 commit into from Nov 13, 2018

Conversation

bramanudom
Copy link
Contributor

The method's JSDoc incorrectly described the method as menu state changes. The comment was also wrapped to prevent going over the 80 character limit.

@torch2424 torch2424 requested review from newmuis and gmajoulet and removed request for newmuis November 13, 2018 02:03
@torch2424
Copy link
Contributor

Triaged to @newmuis and/or @gmajoulet 馃槃 Simple fix, but thought you would like to approve/merge

Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution! 馃帀

@newmuis
Copy link
Contributor

newmuis commented Nov 13, 2018

Woohoo! Thanks @bramanudom!

@newmuis newmuis merged commit 0303c1f into ampproject:master Nov 13, 2018
@bramanudom bramanudom deleted the getting_started branch November 19, 2018 15:39
Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants