Opt in into the desktop full bleed experience. #19271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmajoulet
force-pushed
the
fullbleed_opt_in
branch
from
db82205
to
52807ea
Compare
I think the plan is to test navigating to the next page on scroll, like Slides does. Might not be perfect, but the navigation arrows will help understanding how to navigate the story (cf internal doc) |
newmuis
approved these changes
Nov 14, 2018
| const pages = createPages(story.element, 4, ['cover', '1', '2', '3']); | ||
| story.element.setAttribute('desktop-mode', 'fullbleed'); | ||
|
|
||
| // Don't do this at home. :( |
gmajoulet
force-pushed
the
fullbleed_opt_in
branch
from
52807ea
to
fe4edb4
Compare
Enriqe
approved these changes
Nov 14, 2018
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* Opt in into the desktop full bleed experience. * Renaming UIType.FULLBLEED into UIType.DESKTOP_FULLBLEED.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing a way to opt in into the full bleed desktop experience, through a
<amp-story desktop-mode="fullbleed">parameter.This PR doesn't change anything to the current MOBILE and DESKTOP modes, nor to the
disable-amp-story-desktopexperiment.Demo
#19270