🐛 amp-analytics: allow intersectionRatio to be used on :root #19280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, ${intersectionRatio} expands to "" when applied to :root. This is a
problem for supporting GPT with AMP Inabox because we watch :root and need to
support publishers subscribing to changes in slot visibility. [1] Expand
support to include :root.
[1] https://developers.google.com/doubleclick-gpt/reference#googletag.events.slotVisibilityChangedEvent
zombifier
approved these changes
Nov 13, 2018
keithwrightbos
approved these changes
Nov 13, 2018
zhouyx
approved these changes
Nov 14, 2018
| @@ -363,6 +363,7 @@ export class VisibilityManager { | |||
|
|
|||
| } else { | |||
| state['opacity'] = this.getRootMinOpacity(); | |||
| state['intersectionRatio'] = this.getRootVisibility(); | |||
There was a problem hiding this comment.
One question I have is that interesectionRatio doesn't make much sense for root other than inabox use case. And if we also need to update the document?
There was a problem hiding this comment.
I agree intersectionRatio doesn't make much sense for root outside the Inabox case, but I think it's not a problem to support it?
By "And if we also need to update the document?" did you mean the documentation? I just added that: 9f286fc
There was a problem hiding this comment.
Haha totally meant documentation! LTGM, Thanks!
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
…ect#19280) * amp-analytics: allow intersectionRatio to be used on :root Currently, ${intersectionRatio} expands to "" when applied to :root. This is a problem for supporting GPT with AMP Inabox because we watch :root and need to support publishers subscribing to changes in slot visibility. [1] Expand support to include :root. [1] https://developers.google.com/doubleclick-gpt/reference#googletag.events.slotVisibilityChangedEvent * update docs to not be element specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
${intersectionRatio}expands to""when applied to:root. This is a problem for supporting GPT with AMP Inabox because we watch:rootand need to support publishers subscribing to changes in slot visibility. [1] Expand support to include:root.[1] https://developers.google.com/doubleclick-gpt/reference#googletag.events.slotVisibilityChangedEvent