Stories share menu redesign. #19303
Merged
Stories share menu redesign. #19303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enriqe
approved these changes
Nov 14, 2018
|
LGTM. Percy tests look broken though, can you take a look? |
newmuis
reviewed
Nov 14, 2018
| display: none !important; | ||
| } | ||
|
|
||
| @media (min-width: 1024px) { |
There was a problem hiding this comment.
Can we actually bind this to the desktop/fullbleed attributes instead of using media queries?
There was a problem hiding this comment.
Done (for the desktop-fullscreen only, as this menu doesn't exist on the panels experience)
gmajoulet
force-pushed
the
share_menu_redesign
branch
from
3919734
to
0384c29
Compare
|
Percy should fail in an expected way (slightly bigger font size) this time :) |
gmajoulet
force-pushed
the
share_menu_redesign
branch
from
0384c29
to
1dc80ed
Compare
newmuis
approved these changes
Nov 14, 2018
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* Share menu redesign. * Reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesign of the story share menu to make it match with all our other white drawers, and more colorful. Also adding some responsive magic for when it's displayed on desktop.
The bookend is unchanged, except for the share item label that went from a font size of 10 to 11px.
#19270