馃摉story-ads: update docs #19308
Merged
馃摉story-ads: update docs #19308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torch2424
suggested changes
Nov 15, 2018
| </template> | ||
| </amp-story-auto-ads> | ||
| ```html | ||
| <amp-story-page next-page-no-ad id="page-2" |
| </template> | ||
| ## Insertion Control | ||
| The AMP runtime will determine the best place to insert an ad using our own heuristics. | ||
| If there is a specific position in a story that you wish to never show an ad, you |
There was a problem hiding this comment.
nit: I think this is worded weird (at least to me). Can we do something like:
If there is a specific position in a story that you wish to never show an ad, you can add the
next-page-no-adattribute to the<amp-story-page>. The insertion algorithm will then ignore the page following these<amp-story-page>elements as possible places to place an ad.
There was a problem hiding this comment.
If that sounds too redundant, feel free to just ignore this.
torch2424
approved these changes
Nov 16, 2018
| </template> | ||
| ## Insertion Control | ||
| If there is a specific position in a story that you wish to never show an ad, | ||
| you can add the `next-page-no-ad` attribute an `<amp-story-page>`. The insertion |
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* docs * example * comments * >
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get this in before launch. Better docs cleanup coming this week.