Cleanup the amp-story-hold-to-pause experiment. #19332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newmuis
reviewed
Nov 15, 2018
There was a problem hiding this comment.
Is it safe for code and config to be in the same PR? My assumption was that the prod-config.json would hit prod in the next release, whereas the code would hit canary in the next release and prod in the release after. That would effectively unlaunch the feature for a week, if true.
|
Not safe. The PR check should have failed. |
|
Thanks for catching this! Good news: PR check did fail :) |
gmajoulet
force-pushed
the
clean_hold_to_pause_experiment
branch
from
a5e06b6
to
9df17e8
Compare
|
PTAL |
newmuis
approved these changes
Nov 15, 2018
Enriqe
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup the
amp-story-hold-to-pauseexperiment.#18714 #18715