馃悰story-ads: prevent users getting stuck #19335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newmuis
approved these changes
Nov 15, 2018
|
@calebcordry could you further clarify why backwards navigation behaves differently than forward navigation here? |
|
The problem is that going forwards shows you the ad so that then the counter was reset correctly. If you go backwards the counter was not reset so that the algorithm kept thinking you had seen enough pages and would try to insert an ad on the following page. This problem was introduced in #18959 because we changed the count to be reset on view. Before that it would be reset on insert. |
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user taps forward enough times that an ad is inserted but not viewed, then taps backwards, at each backwards navigation event amp-story-auto-ads tries to insert another ad.
This is a regression introduced in #18959 which reset the counter when an ad is viewed (previously it was being reset when the ad was inserted).
I still think that this is the right approach, so this fixes the problem by introducing a new flag that signifies that we are in the state where an ad has been inserted but has not yet been seen.