Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Disable flaky desktop stories test #19390

Merged
merged 1 commit into from Nov 19, 2018
Merged

✅ Disable flaky desktop stories test #19390

merged 1 commit into from Nov 19, 2018

Conversation

newmuis
Copy link
Contributor

@newmuis newmuis commented Nov 19, 2018 •
edited

Desktop story tests are still flaking due to the share pill.

/cc @Enriqe
/cc @danielrozenberg in case you want to know this for some reason

@newmuis newmuis merged commit d76182a into master Nov 19, 2018
@Enriqe
Copy link
Contributor

Enriqe commented Nov 26, 2018

What does the flaky flag do? Will the test still run?

@gmajoulet
Copy link
Contributor

Nope it skips it: https://github.com/ampproject/amphtml/blob/master/test/visual-diff/visual-tests#L130-L134

@rsimha rsimha deleted the newmuis-patch-6 branch November 26, 2018 21:08
Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Nov 28, 2018
@newmuis @Enriqe
Disable flaky tests (ampproject#19390)
0c212d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@newmuis @Enriqe @gmajoulet @googlebot @ampprojectbot