♻️ Add DomElement type for media pool #19396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmajoulet
approved these changes
Nov 20, 2018
alanorozco
approved these changes
Nov 20, 2018
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* Add DomElement type * Remove non-type/non-docs changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a third typedef for media pool:
DomElementDef. The three types are now:PlaceholderElementDef: This element is a placeholder for media elements. If there is space in the pool, media elements can be swapped into the DOM in place of placeholder elements. If not, the placeholder element remains in the DOM.PoolBoundElementDef: This element is allocated by the media pool. It is swapped in place of placeholder elements, and is the media element that gets played in the UI.DomElementDef: A union ofPlaceholderElementDefandPoolBoundElementDef. Essentially, "we're not sure yet; we'll need to check which type this is, but it's definitely one of the two."This PR should be just type and documentation changes.