Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @octokit/rest to v16 #19418

Merged
merged 1 commit into from Dec 11, 2018

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Nov 21, 2018

This PR contains the following updates:

Package Type Update Change References
@​octokit/rest devDependencies major 15.18.0 -> 16.2.0 source

Release Notes

octokit/rest.js

v16.2.0

Compare Source

Features

v16.1.0

Compare Source

Features
  • package: error.request is now set to the request options that resulted in an error, via @​octokit/request@2.2.0 (7497080)

v16.0.5

Compare Source

Bug Fixes
  • typescript: octokit.authenticate definitions using overloads (23ca22d)

v16.0.4

Compare Source

Bug Fixes
  • package: remove node-fetch dependency (1d2ed27)

Merci @​pvdlg for their help 💐

v16.0.3

Compare Source

Bug Fixes
  • aliasing octokit.gitdataoctokit.git, octokit.authorizationoctokit.oauthAuthorizations, octokit.pullRequestsoctokit.pulls (0766d51)

Thanks to @​hipstersmoothie for their help 💐

v16.0.2

Compare Source

Bug Fixes

v16.0.1

Compare Source

To upgrade to v16, make sure you have the latest v15 release installed first:

npm install @​octokit/rest@15.18.0

Now run the tests and look for DEPRECATED messages in the logs. Once you see no more deprecations, upgrading to v16 should cause no problems.

BREAKING CHANGES
  • all previously deprecated methods have been removed

  • preview headers that are not required to use an API have been removed

  • .gitdata.getTags() has been removed. Use .gitdata.listRefs({namespace: tags}) instead

  • Methods for undocumented endpoints have been removed.

    Instead of client.users.getById({id}) use client.request({method: GET, url: /user/:id, id})
    Instead of client.repos.getById({id}) use client.request({method: GET, url: /repositories/:id, id})

  • octokit.enterprise.* methods have been removed. They will be moved into a plugin like https://github.com/octokit/plugin-scim.js

  • routes: the milestone parameter is no longer validated using a regex as it cannot be derived from octokit/routes

  • travis: dropped support for node 4

  • error.message is no longer a JSON string containing GitHub’s error message. Instead the JSON is parsed internally and error properties are assigned with its value. This is not technically a breaking change but a bug fix, but as this bug was around for a long time and plenty of apps depend on JSON.parse(error.message) to be working, we treat it as a breaking change by way of precaution

  • error.status is now the response status code number. The status text is no longer returned

Features
Bug Fixes
  • routes: remove validation for milestone parameter as it cannot be derived from octokit/routes (4d04d17)
  • only set preview headers required to use the API (1628821)
  • parse JSON from GitHub error messages (dd6306e)
Continuous Integration
  • travis: drop tests in node 4 & 9, test in node 10 (ad8b1e5)
Bug Fixes in v16.0.1
  • typescript: Adding return types (18ac5bf), closes #​1116
  • typescript: Adding the noImplicitAny flag to validate:ts (ef4d35a)
  • typescript: Github.plugin is a static method, not an instance method (01763bf)
  • typescript: include a header object when transforming Content-Type and Content-Length to headers.content-type and headers.content-length (0b9cc37)

Thanks @​mamodom for your great help with these Typescript fixes 💐

v16.0.0

Compare Source

To upgrade to v16, make sure you have the latest v15 release installed first:

npm install @​octokit/rest@15.18.0

Now run the tests and look for DEPRECATED messages in the logs. Once you see no more deprecations, upgrading to v16 should cause no problems.

BREAKING CHANGES
  • all previously deprecated methods have been removed

  • preview headers that are not required to use an API have been removed

  • .gitdata.getTags() has been removed. Use .gitdata.listRefs({namespace: tags}) instead

  • Methods for undocumented endpoints have been removed.

    Instead of client.users.getById({id}) use client.request({method: GET, url: /user/:id, id})
    Instead of client.repos.getById({id}) use client.request({method: GET, url: /repositories/:id, id})

  • octokit.enterprise.* methods have been removed. They will be moved into a plugin like https://github.com/octokit/plugin-scim.js

  • routes: the milestone parameter is no longer validated using a regex as it cannot be derived from octokit/routes

  • travis: dropped support for node 4

  • error.message is no longer a JSON string containing GitHub’s error message. Instead the JSON is parsed internally and error properties are assigned with its value. This is not technically a breaking change but a bug fix, but as this bug was around for a long time and plenty of apps depend on JSON.parse(error.message) to be working, we treat it as a breaking change by way of precaution

  • error.status is now the response status code number. The status text is no longer returned

Features
Bug Fixes
  • routes: remove validation for milestone parameter as it cannot be derived from octokit/routes (4d04d17)
  • only set preview headers required to use the API (1628821)
  • parse JSON from GitHub error messages (dd6306e)
Continuous Integration
  • travis: drop tests in node 4 & 9, test in node 10 (ad8b1e5)

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@rsimha rsimha changed the title Update dependency @octokit/rest to v16 rebase! Update dependency @octokit/rest to v16 Nov 26, 2018
@renovate-bot renovate-bot changed the title rebase! Update dependency @octokit/rest to v16 Update dependency @octokit/rest to v16 Nov 27, 2018
@rsimha rsimha merged commit bbc11a9 into ampproject:master Dec 11, 2018
@renovate-bot renovate-bot deleted the renovate/octokit-rest-16.x branch December 11, 2018 21:32
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants