🐛 [amp-analytics] Pass the canonical url on every Parse.ly Analytics pageview request

[cwisecarver]

Passing the canonical url on pageview requests will allow us to properly associate self-hosted (non-CDN hosted) AMP traffic with the canonical URL of the content. We have had a customer manually add this change to their AMP configuration and verified that the traffic post-change was being correctly associated. I also tested this locally using gulp default and the analytics-vendors.amp.html page to confirm the HTTP request sent by the pageview event was correct.

[zhouyx]

@cwisecarver Please also update the test file. Thanks

[cwisecarver]

Sorry @zhouyx . I'm a little out of practice. I ran gulp check-all and thought that also ran the tests. I updated the test file and it's passing locally now.

[cwisecarver]

Any update on this @zhouyx ? It's a pretty small configuration change and we have customers waiting on it.

[zhouyx]

@cwisecarver Sorry about the delay. LGTM.

One thing to mention is that the meta data object will be encoded to metadata={%22canonical_url%22:%22http%3A%2F%2Flocalhost%3A8000%2Fexamples%2Fanalytics.amp.html%22} here.
let me know if it doesn't work for you. Or i'll go ahead and merge the change.

[cwisecarver]

@zhouyx No worries about the delay.

That does work. I'm expecting the JSON to be URL encoded. I just tested that exact snippet you posted and it parsed correctly on our side.

Thanks!

[zhouyx]

@cwisecarver Thank you for confirming! PR merged.

[cwisecarver]

@zhouyx I imagine this will end up in the release on January 9th not December 18th, correct?

[zhouyx]

@cwisecarver The change will be in canary cut today. But since there will be no prod release next, the change will hit prod on January 2nd.