馃彈馃毊 Remove legacy bundle-size check #19541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrozenberg
force-pushed
the
remove-legacy-bundle-size
branch
from
5221b4e
to
c0a1616
Compare
danielrozenberg
force-pushed
the
remove-legacy-bundle-size
branch
from
c0a1616
to
2b9eb33
Compare
|
/to @erwinmombay @rsimha this is ready to be reviewed and merged 馃帀 |
danielrozenberg
changed the title
rsimha
approved these changes
Jan 23, 2019
danielrozenberg
added a commit
to ampproject/amphtml-build-artifacts
that referenced
this pull request
Jan 23, 2019
Unused since ampproject/amphtml#19541
danielrozenberg
added a commit
to ampproject/amphtml-build-artifacts
that referenced
this pull request
Jan 28, 2019
Unused since ampproject/amphtml#19541
danielrozenberg
pushed a commit
to ampproject/amphtml-build-artifacts
that referenced
this pull request
Feb 25, 2019
Unused since ampproject/amphtml#19541, and hopefully for reals this time
danielrozenberg
added a commit
to ampproject/amphtml-build-artifacts
that referenced
this pull request
Feb 25, 2019
Unused since ampproject/amphtml#19541, and hopefully for reals this time
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Remove legacy bundle-size check * Remove unnecessary space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old bundle-size checks based on
.max_size. Bundle sizes will no longer fail Travis builds. Woohoo!DO NOT MERGE until: