Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow passing ampdoc to Services.urlForDoc() #19602

Merged
merged 6 commits into from Dec 10, 2018
Merged

Disallow passing ampdoc to Services.urlForDoc() #19602

merged 6 commits into from Dec 10, 2018

Conversation

dreamofabear
Copy link

@dreamofabear dreamofabear commented Dec 3, 2018 •
edited

Partial for #16322.

@dreamofabear
Copy link
Author

/to @jridgewell

@dreamofabear dreamofabear mentioned this pull request Dec 7, 2018
Merged
2 tasks
@dreamofabear dreamofabear merged commit c49fcd9 into ampproject:master Dec 10, 2018
@dreamofabear dreamofabear deleted the service-noampdoc-url branch December 10, 2018 22:54
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
Disallow passing ampdoc to Services.urlForDoc() (ampproject#19602)
70a335e 
* Disallow passing ampdoc to Services.urlForDoc()

* Fix types.

* Fix test-linker-manager.js.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dreamofabear @jridgewell @googlebot