No amp4test log on travis. #19611
No amp4test log on travis. #19611
Conversation
|
I think it's fine? I assume running test locally is most in dev / debug mode? |
|
Running all tests locally is a routine workflow for the infra team, so these logs do come in the way due to how often they're printed. A couple suggestions:
|
|
@rsimha instead of introducing another flag, what's your attitude to reusing the existing |
|
Good idea, using |
|
@rsimha changed to read |
| * @param {*} messages | ||
| */ | ||
| function log(...messages) { | ||
| if (!process.env.AMP_TEST) { |
There was a problem hiding this comment.
If this environment variable isn't used anywhere else, it can be removed from runtime_test.js.
build-system/amp4test.js
Outdated
| * @param {*} messages | ||
| */ | ||
| function log(...messages) { | ||
| if (!process.env.AMP_TEST) { | ||
| console.log(messages); | ||
| if (argv.files) { |
There was a problem hiding this comment.
I just realized we also have a verbose flag. You could use that instead of (or in addition to) files if you'd like.
There was a problem hiding this comment.
SG. switched to --verbose
* No amp4test log on travis. * read --files to enable logging * Update js doc * clean up * print error in correct format * also do --verbose * use --verbose * Update js doc
Still want logs on local testing.