Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip failing test #19645

Merged
merged 3 commits into from Dec 5, 2018
Merged

Skip failing test #19645

merged 3 commits into from Dec 5, 2018

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented Dec 5, 2018 •
edited

Attempt to fix travis build....

lannka
lannka approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@lannka lannka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls create an issue and have a link somewhere

@zhouyx zhouyx merged commit 400ee87 into ampproject:master Dec 5, 2018
@zhouyx
Copy link
Contributor Author

zhouyx commented Dec 5, 2018

Follow up Issue #19647

@choumx I merged this PR first to unblock people. But looks like all test failure are related to bind, please take a look and make sure that is is working as expected.

dreamofabear pushed a commit that referenced this pull request Dec 5, 2018
@zhouyx
Skip failing test (#19645)
f1aec32 
* skip bind test

* add todo

* skip more test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lannka lannka lannka approved these changes

@dreamofabear dreamofabear Awaiting requested review from dreamofabear

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhouyx @lannka @googlebot @ampprojectbot