Publisher opt in into a story landscape fullbleed desktop + mobile experience. #19646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enriqe
reviewed
Dec 5, 2018
| box-sizing: border-box !important; | ||
| min-height: 100vh !important; | ||
| padding: 104px 156px 64px !important; | ||
| margin: 0 !important; | ||
| } | ||
|
|
||
| [desktop] .i-amphtml-story-bookend-inner::before. | ||
| [desktop-fullbleed] .i-amphtml-story-bookend-inner::before { |
There was a problem hiding this comment.
Nope, we actually want that opacity layer, even on desktop :))
newmuis
requested changes
Dec 5, 2018
There was a problem hiding this comment.
FYI I don't think we can use Array.prototype.includes, but are supposed to use findIndex from array.js and compare it to -1.
I feel like this is the kind of thing @jridgewell would know for sure.
newmuis
reviewed
Dec 5, 2018
| this.element.getAttribute(Attributes.SUPPORTED_ORIENTATIONS); | ||
|
|
||
| if (!supportedOrientationsAttribute) { | ||
| return ['portrait']; |
There was a problem hiding this comment.
I have a preference for making constants out of 'portrait' and 'landscape', so that we get compiler errors instead of bugs if we mistype them
|
PTAL |
gmajoulet
force-pushed
the
supported_orientations
branch
from
8fce743
to
c40a6ea
Compare
|
Friendly ping |
newmuis
approved these changes
Dec 11, 2018
Enriqe
approved these changes
Dec 11, 2018
|
|
gmajoulet
force-pushed
the
supported_orientations
branch
from
c40a6ea
to
eb94bb8
Compare
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
…perience. (ampproject#19646) * Renaming UIType.DESKTOP into UIType.DESKTOP_PANELS. * Replacing [desktop] CSS selectors, and supported-orientations opt in. * Detecting the supported-orientations config. * Allow landscape mobile if opted in. * Reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supported-orientations="portrait,landscape"on the<amp-story>tag (pending validation)supported-orientations="portrait"(which is the default), or nosupported-orientationsattribute at alllandscapeoptin also allows mobile landscapeUIType.DESKTOPintoUIType.DESKTOP_PANELS[desktop]now means "Viewport size should trigger a desktop UI", which could be PANELS or FULLBLEED depending on the configurationi-amphtml-story-desktop-panelsandi-amphtml-story-desktop-fullbleedto tweak the CSSamp-story-desktop.cssintoamp-story-desktop-panels.cssDemo
#19270