Disable headless mode, fix tests broken on Chrome 71 #19658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
changed the title
|
Weird, these tests only fail on headless Chrome mode. |
|
Blob URLs broken on headless Chrome 71: puppeteer/puppeteer#3463 |
|
/to @estherkim /cc @rsimha |
dreamofabear
changed the title
|
Omg, tests passed. @estherkim quick, before my luck runs out. |
estherkim
approved these changes
Dec 6, 2018
dreamofabear
commented
Dec 6, 2018
|
Delayed LGTM. Thanks for investigating this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19647. Fixes and unskips amp-bind tests failing on Chrome 71.