Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sauce Connect to 4.5.2 #19661

Merged
merged 1 commit into from Dec 5, 2018
Merged

Update Sauce Connect to 4.5.2 #19661

merged 1 commit into from Dec 5, 2018

Conversation

dreamofabear
Copy link 

5 Dec 17:20:02 - ***********************************************************
5 Dec 17:20:02 - A newer version of Sauce Connect (build 4485) is available!
5 Dec 17:20:02 - Download it here:
5 Dec 17:20:02 - https://saucelabs.com/downloads/sc-4.5.2-linux.tar.gz
5 Dec 17:20:02 - ***********************************************************

https://travis-ci.org/ampproject/amphtml/jobs/463938112

rsimha
rsimha approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @estherkim

@dreamofabear
Copy link
Author

@danielrozenberg Looks like PRs from amphtml branches (vs. from forks) make the bundle-size check fail.

@danielrozenberg
Copy link
Member

Interesting... I'll check!

@danielrozenberg
Copy link
Member

Looks like it was a temporary glitch. I retrigged it manually and the check is now pending. Gotta run the Travis integration tests again to get the size (but I'll let you decide when to do that, as I don't know if you're planning on adding more commits to the PR)

image

@dreamofabear dreamofabear merged commit 87ae399 into master Dec 5, 2018
@dreamofabear dreamofabear deleted the sc-4.5.2 branch December 5, 2018 20:24
@rsimha rsimha mentioned this pull request Feb 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

@estherkim estherkim estherkim approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dreamofabear @danielrozenberg @rsimha @estherkim @googlebot