Add integration tests for <amp-analytics type=googleanalytics> #19674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcordry
approved these changes
Dec 6, 2018
| "account": "UA-67833617-1" | ||
| }, | ||
| "requests": { | ||
| "host": "${RequestBank.getUrl(1)}" |
There was a problem hiding this comment.
I thought we were going to name these?
zhouyx
reviewed
Dec 6, 2018
| document.cookie = '_ga=;expires=' + new Date(0).toUTCString(); | ||
| }); | ||
|
|
||
| it('should assign new cid', () => { |
There was a problem hiding this comment.
Do we have test to get stored cid? Or is that not possible to do.
There was a problem hiding this comment.
the test above is parsing CID from cookie
|
Decided to move the CLIENT_ID related tests out of this googleanalytics specific tests #19709 |
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
…oject#19674) * Add integration tests for <amp-analytics type=googleanalytics> * remove * skip one failing amp-bind test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19708