New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Implemented Fuzzy Search through an API on the Dev Dashboard #19676
✨Implemented Fuzzy Search through an API on the Dev Dashboard #19676
Conversation
…shboard-fuzzy-finding
Thanks for this, looks awesome! Before I take a more technical look, would you mind styling the list so that each row takes a constant amount of space? I see it jumping in size in the gif, which is rather jarring. This might be due to amp-list requiring a fixed-size, but I'm not sure. I'm going to give it a go. |
@alanorozco Fixed the column size! Was because I used Also, I fixed all the linting errors 😄 |
Two ideas:
Also note that I made some small changes to this PR, so make sure to pull. |
…shboard-fuzzy-finding
Fixed tests, and presubmit errors. Also, made sure to pull down your commits and everything 😄
I agree this is awesome! Since this PR is already kinda big, do you mind if I open an issue and implement this another time? Just to keep this PR size small.
I definitely agree that we should move to dynamic resizing for |
@torch2424 Awesome! One more request, could you please make sure the row height is the same as before? |
…ject#19676) * Created an API for dashboard, and a fuzzy search endpoint * Got the client side of fuzzy searching working * Got fuzzy searching working * Still working on fuzzy finding * Got debounced input * Finished up fuzzy search for files * Finished dashboard fuzzy finding * Fixed the space between column styling * Fixed linting errors * Search box styling, structure * naming * Fixed huge rows, and tests * Made the rows and columns the same sizes as they were originally
This implements fuzzy searching of the current directory using a new REST API for the dashboard, amp-list, amp-mustache, and amp-bind.
api/
directory for alldashboard/api/*
requests. Starting with/api/api.js
GET /listing
api route. Takes apath
andsearch
query param.GET /listing
api route.search
query param for our amp listsrc
.See examples below. Tested API using Postman. Tested UI in all Chrome Canary, Firefox, and Safari.