adding babel plugin for IS_DEV and IS_MINIFIED transformation
#19690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
reviewed
Dec 10, 2018
| * @param {Object} babelTypes | ||
| */ | ||
| module.exports = function(babelTypes) { | ||
| const {types: t} = babelTypes; |
There was a problem hiding this comment.
Nit: inline this into the parameter
| const {id, init} = path.node; | ||
| if (t.isIdentifier(id, {name: 'IS_DEV'}) | ||
| && t.isBooleanLiteral(init, {value: true})) { | ||
| path.replaceWith( |
There was a problem hiding this comment.
I actually tried doing that...
can you please explain why line 73 is still true after this transform
There was a problem hiding this comment.
…emo-amp-custom-runner-part1
jridgewell
approved these changes
Dec 12, 2018
…emo-amp-custom-runner-part1
erwinmombay
approved these changes
Dec 12, 2018
…emo-amp-custom-runner-part1
…emo-amp-custom-runner-part1
…emo-amp-custom-runner-part1
prateekbh
force-pushed
the
remo-amp-custom-runner-part1
branch
from
2148a72
to
1d159b8
Compare
cathyxz
pushed a commit
to cathyxz/amphtml
that referenced
this pull request
Dec 17, 2018
…pproject#19690) * adding babel plugin for const transformation * adding test for transformer * fixing the is fortesting condition * fixing lints * fixing lints * fixing `is_minified` always true condition * lint fixes * fixing babel transformer * fixes copyrights
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
…pproject#19690) * adding babel plugin for const transformation * adding test for transformer * fixing the is fortesting condition * fixing lints * fixing lints * fixing `is_minified` always true condition * lint fixes * fixing babel transformer * fixes copyrights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19618
IS_DEVto false andIS_MINIFIEDto true if--isfortestingis not present