🚀 HTML Template Tag Transform to eliminate poor transpilation issues #19704

kristoferbaxter · 2018-12-07T00:37:55Z

Updated Single Pass Pipeline with a Babel transform to remove poor transpilation to ES5 done by Closure Compiler on Tagged Template literals used to create markup.

Addresses: #14658, #14657, #15145.

googlebot · 2018-12-07T00:37:57Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot · 2018-12-07T00:38:16Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

...gins/babel-plugin-transform-html-template/test/fixtures/transform-assertions/direct/input.js

...ns/babel-plugin-transform-html-template/test/fixtures/transform-assertions/indirect/input.js

jridgewell · 2018-12-07T00:46:06Z

build-system/babel-plugins/babel-plugin-transform-html-template/index.js

+  return minify(templateLiteral.quasis[0].value.cooked, {
+    removeComments: true,
+    collapseWhitespace: true,
+    removeAttributeQuotes: true,


It's a fancy minifier.

jridgewell · 2018-12-07T00:49:09Z

...gins/babel-plugin-transform-html-template/test/fixtures/transform-assertions/direct/input.js

+  <span>html usage</span>
+  <span>more spans</span>
+</p>`);
+console.log(htmlFor(element)`<p>


Also need a test for an element with an attribute using both kinds of quotes (you'll have to use a multi word attribute to get it to persist).

Addressed with c262f65.

jridgewell

Oh, and if you want to get really fancy, you should hoist this to the highest scope possible. path.get('arguments.0').hoist()

googlebot · 2018-12-07T01:04:46Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot · 2018-12-07T01:19:17Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

kristoferbaxter · 2018-12-07T01:46:40Z

On hoisting, let's address that in a separate PR.

googlebot · 2018-12-07T01:49:32Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot · 2018-12-07T01:54:04Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

googlebot · 2018-12-10T23:15:42Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot · 2018-12-10T23:18:11Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

googlebot · 2018-12-10T23:41:45Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot · 2018-12-10T23:42:36Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

…mpproject#19704)

HTML Template Tag Transform to eliminate poor transpilation issues

fa39248

kristoferbaxter requested review from jridgewell and erwinmombay December 7, 2018 00:37

googlebot added the cla: no label Dec 7, 2018

kristoferbaxter added cla: yes and removed cla: no labels Dec 7, 2018

jridgewell reviewed Dec 7, 2018

View reviewed changes

Additional tests from PR feedback

2ecf7a0

googlebot added cla: no and removed cla: yes labels Dec 7, 2018

Tests for quote removal on attributes

c262f65

kristoferbaxter added cla: yes and removed cla: no labels Dec 7, 2018

OK for console.log in Babel transform

def1b8d

googlebot added cla: no and removed cla: yes labels Dec 7, 2018

kristoferbaxter added cla: yes and removed cla: no labels Dec 7, 2018

jridgewell approved these changes Dec 7, 2018

View reviewed changes

Skip flaky test for Chrome Dev

5d35bb7

googlebot removed the cla: yes label Dec 10, 2018

googlebot added the cla: no label Dec 10, 2018

kristoferbaxter added cla: yes and removed cla: no labels Dec 10, 2018

Latest master

02ebc02

googlebot added cla: no and removed cla: yes labels Dec 10, 2018

kristoferbaxter added cla: yes and removed cla: no labels Dec 10, 2018

aghassemi merged commit 8598bbe into ampproject:master Dec 11, 2018

This was referenced Dec 11, 2018

Build Step: Transform Tagged Template Literals into Simple Code #14658

Closed

Build step: Reduce static template whitespace #14657

Closed

Build step: Collapse static template comments #15145

Closed

kristoferbaxter deleted the html-templates branch December 11, 2018 16:23

kristoferbaxter mentioned this pull request Dec 12, 2018

🚀 Hoist templates and ensure duplicates are not added to bundle #19812

Merged

noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019

🚀 HTML Template Tag Transform to eliminate poor transpilation issues (a…

e4b15c2

…mpproject#19704)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🚀 HTML Template Tag Transform to eliminate poor transpilation issues #19704

🚀 HTML Template Tag Transform to eliminate poor transpilation issues #19704

kristoferbaxter commented Dec 7, 2018

googlebot commented Dec 7, 2018

googlebot commented Dec 7, 2018

jridgewell Dec 7, 2018

kristoferbaxter Dec 7, 2018

jridgewell Dec 7, 2018

kristoferbaxter Dec 7, 2018

jridgewell left a comment •

edited

googlebot commented Dec 7, 2018

googlebot commented Dec 7, 2018

kristoferbaxter commented Dec 7, 2018

googlebot commented Dec 7, 2018

googlebot commented Dec 7, 2018

googlebot commented Dec 10, 2018

googlebot commented Dec 10, 2018

googlebot commented Dec 10, 2018

googlebot commented Dec 10, 2018

🚀 HTML Template Tag Transform to eliminate poor transpilation issues #19704

🚀 HTML Template Tag Transform to eliminate poor transpilation issues #19704

Conversation

kristoferbaxter commented Dec 7, 2018

googlebot commented Dec 7, 2018

googlebot commented Dec 7, 2018

jridgewell Dec 7, 2018

Choose a reason for hiding this comment

kristoferbaxter Dec 7, 2018

Choose a reason for hiding this comment

jridgewell Dec 7, 2018

Choose a reason for hiding this comment

kristoferbaxter Dec 7, 2018

Choose a reason for hiding this comment

jridgewell left a comment • edited

Choose a reason for hiding this comment

googlebot commented Dec 7, 2018

googlebot commented Dec 7, 2018

kristoferbaxter commented Dec 7, 2018

googlebot commented Dec 7, 2018

googlebot commented Dec 7, 2018

googlebot commented Dec 10, 2018

googlebot commented Dec 10, 2018

googlebot commented Dec 10, 2018

googlebot commented Dec 10, 2018

jridgewell left a comment •

edited