[amp-story] Stop stubbing querySelectorAll in tests 馃悰 #19718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enriqe
changed the title
gmajoulet
approved these changes
Dec 7, 2018
newmuis
reviewed
Dec 7, 2018
|
|
||
| const expected = { | ||
| [MediaType.AUDIO]: 3, | ||
| [MediaType.VIDEO]: 4, | ||
| [MediaType.VIDEO]: 3, |
There was a problem hiding this comment.
I'm not sure I understand what's going on here, but why does the expected number of max videos in the pool decrease with this change?
There was a problem hiding this comment.
Just because the test was faking that there were two amp-video elements, and I only appended one to make the test look cleaner. But let me know if you think it's better to keep as it was and append two amp-videos.
There was a problem hiding this comment.
Got it. Thanks for the explanation. Agree this makes it easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19716
Stubbing
querySelectorAllin theamp-storyelement was causing the tests to break.When deleting the element from the DOM in the
afterEachhook, thecustom-elementspolyfill will use the element'squerySelectAllto disconnect that node and its children. This just started breaking because of a recent change which forces installation of thecustom-elements.jsv1 polyfill.